On 31/05/2023 20:00, Detlev Casanova wrote: >>> + clock-names: >>> + items: >>> + - const: xtal >> >> I don't think xtal is the best of names here. It generally is used as >> an abbreviation for crystal. And the commit message is about there not >> being a crystal, but an actual clock. >> >> How is this clock named on the datasheet? > > In the case of the PHY I used (RTL8211F), it is EXT_CLK. But this must be > generic to any (ethernet) PHY, so using ext_clk to match it would not be > good either. > > Now this is about having an external clock, so the ext_clk name makes sense in > this case. > > I'm not pushing one name or another, let's use what you feel is more natural. Just drop the name. Best regards, Krzysztof
