On Wednesday, May 31, 2023 11:16:46 A.M. EDT Andrew Lunn wrote: > On Wed, May 31, 2023 at 11:03:39AM -0400, Detlev Casanova wrote: > > Ethernet PHYs can have external an clock that needs to be activated before > > probing the PHY. > > > > Signed-off-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx> > > --- > > > > .../devicetree/bindings/net/ethernet-phy.yaml | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > > b/Documentation/devicetree/bindings/net/ethernet-phy.yaml index > > 4f574532ee13..e83a33c2aa59 100644 > > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > > > > @@ -93,6 +93,16 @@ properties: > > the turn around line low at end of the control phase of the > > MDIO transaction. > > > > + clock-names: > > + items: > > + - const: xtal > > I don't think xtal is the best of names here. It generally is used as > an abbreviation for crystal. And the commit message is about there not > being a crystal, but an actual clock. > > How is this clock named on the datasheet? In the case of the PHY I used (RTL8211F), it is EXT_CLK. But this must be generic to any (ethernet) PHY, so using ext_clk to match it would not be good either. Now this is about having an external clock, so the ext_clk name makes sense in this case. I'm not pushing one name or another, let's use what you feel is more natural. Detlev.
