On 22:37-20230531, Kumar, Udit wrote: [...] > > + secure_proxy_mcu: mailbox@2a480000 { > I think, we should start name as mailbox@2a380000 > > + compatible = "ti,am654-secure-proxy"; > > + #mbox-cells = <1>; > > + reg-names = "target_data", "rt", "scfg"; > > + reg = <0x0 0x2a480000 0x0 0x80000>, > > + <0x0 0x2a380000 0x0 0x80000>, > > + <0x0 0x2a400000 0x0 0x80000>; > > I think, we should have increasing order for reg. Unless there is some > strong reason to keep in this way. Binding is defined this way - the items section in the binding enforces the order. As a result the first reg entry(target_data) address causes the node name. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D