Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/05/2023 14:42, Matthias Brugger wrote:
>>> +    soc {
>>> +      #address-cells = <2>;
>>> +      #size-cells = <2>;
>>> +
>>> +      auxadc: auxadc@11001000 {
>>> +        compatible = "mediatek,mt8173-auxadc";
>>> +        reg = <0 0x11001000 0 0x1000>;
>>> +        clocks = <&pericfg CLK_PERI_AUXADC>;
>>> +        clock-names = "main";
>>> +        #io-channel-cells = <1>;
>>> +      };
>>> +
>>> +      apmixedsys: clock-controller@10209000 {
>>> +        compatible = "mediatek,mt8173-apmixedsys";
>>> +        reg = <0 0x10209000 0 0x1000>;
>>> +        #clock-cells = <1>;
>>> +      };
>>
>> Drop both examples, not really relevant to thermal. It grows the example
>> with code already documented somewhere else.
>>
> 
> auxadc and apmixedsys are no examples. They are referenced by the thermal node 
> as described in the binding. Without them the example won't be complete.
> 

The example is complete, because you have phandles and that's enough.
the auxadc and apmixedsys have their own examples in their own bindings
- no need to duplicate them here.

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux