From: ChiYuan Huang <cy_huang@xxxxxxxxxxx> The RT9467 charger enable pin is an external signal that used to enable battery charging. From the datasheet, the active level is low. Although it's already configured to logic low at driver probe function, but the current binding example declared it as 'GPIO_ACTIVE_LOW', this causes this pin be output high and disable battery charging. Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger") Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx> --- Hi, This patch is to fix the active level for charger enable gpio polarity. Currently, the wrong active level makes the user confused and unexpectedly disable battery charging by default. --- Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml index 3723717..cdc7678 100644 --- a/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml +++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml @@ -69,7 +69,7 @@ examples: reg = <0x5b>; wakeup-source; interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>; - charge-enable-gpios = <&gpio26 1 GPIO_ACTIVE_LOW>; + charge-enable-gpios = <&gpio26 1 GPIO_ACTIVE_HIGH>; rt9467_otg_vbus: usb-otg-vbus-regulator { regulator-name = "rt9467-usb-otg-vbus"; -- 2.7.4