On 29/05/2023 22:04, Frank Li wrote: > Extend Freescale eDMA driver bindings to support eDMA3 IP blocks in > i.MX8QM and i.MX8QXP SoCs. In i.MX93, both eDMA3 and eDMA4 are now. > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > .../devicetree/bindings/dma/fsl,edma.yaml | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > index 5fd8fc604261..eed12687b0c9 100644 > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > @@ -21,6 +21,10 @@ properties: > - enum: > - fsl,vf610-edma > - fsl,imx7ulp-edma > + - fsl,imx8qm-edma > + - fsl,imx8qm-adma > + - fsl,imx93-edma3 > + - fsl,imx93-edma4 What are these last two? What is "3" and "4"? > - items: > - const: fsl,ls1028a-edma > - const: fsl,vf610-edma > @@ -101,6 +105,22 @@ allOf: > reg: > maxItems: 2 > > + - if: > + properties: > + compatible: > + contains: > + anyOf: > + - const: fsl,imx8qm-edma > + - const: fsl,imx8qm-adma > + - const: fsl,imx93-edma3 > + - const: fsl,imx93-edma4 > + then: > + properties: > + reg: > + maxItems: 1 > + interrupts: > + maxItems: 64 That's odd. What about the names? What about minItems? Anyway, this wasn't tested - you will have failures with dtbs_check. Best regards, Krzysztof
