On Mon, May 29, 2023 at 02:47:30PM +0100, Bryan O'Donoghue wrote: > On 29/05/2023 13:47, Stephan Gerhold wrote: > > All definitions in pm8916.dtsi use the &pm8916_ label suffix, only the > > That's a prefix_ not a _suffix > Right, my bad :) > > codec uses the &wcd_codec label. &wcd_codec is confusing because the > > codec on MSM8916 is split into a "wcd-digital" and "wcd-analog" part > > and both could be described with &wcd_codec. > > > > Let's just name it &pm8916_codec so it's consistent with all other PMIC > > device nodes. > > I'm not sure that's really consistent throught the dts/yaml TBH but, I do > think the pm8196 name is more meaningful and clear. > > What is wcd supposed to stand for anyway ? Its probably obvious but I prefer > pm8916_code since that *is* obvious. > I think WCD is the typical prefix Qualcomm uses for its dedicated audio codec chips. There is no WCD* chip on MSM8916/PM8916 because the codec was split and integrated partly into the SoC and partly into the PMIC. I guess the "wcd" name just survived for historical reasons. Looking at "WCD9335 Audio Codec - Device Specification - LM80-P2751-29 Rev. A - Table 1-2 Terms and acronyms" apparently WCD = WSP codec device WSP = Wafer-scale package WSA = WSP smart amplifier > > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > > Seems like a valid change but, consider amending your commit log. > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > Perhaps Bjorn can fix "prefix" -> "suffix" in the commit message when applying, doesn't seem worth resending for that alone. (Will fix it of course in case I send a v2 for other reasons!) Thanks, Stephan
