On Sun, 30 Apr 2023 20:20:52 +0200, Luca Weiss wrote: > Clean up some issues with the driver I've noticed while working on it, > then fix the magnitude handling which previously resulted the driver > discarding the upper 8 bits of the magnitude value, and finally we can > add the drv260x to the APQ8026 Huawei Watch. > > While the "fix magnitude handling" commit technically changes behavior > and could change behavior of existing user space applications that deal > with this quirky behavior, it's definitely not correct and results in > very unexpected behavior if the user space doesn't look out for it > (meaning only use 0x00-0xFF magnitude, and also know that the magnitude > was interpreted as signed value, see more details in the commit message > there). > > [...] Applied, thanks! [5/5] ARM: dts: qcom: apq8026-huawei-sturgeon: Add vibrator commit: ad318f9ce5a2e815816bfcf7f187a3ac32905523 Best regards, -- Bjorn Andersson <andersson@xxxxxxxxxx>