On Sun, Apr 30, 2023 at 08:20:52PM +0200, Luca Weiss wrote: > Clean up some issues with the driver I've noticed while working on it, > then fix the magnitude handling which previously resulted the driver > discarding the upper 8 bits of the magnitude value, and finally we can > add the drv260x to the APQ8026 Huawei Watch. > > While the "fix magnitude handling" commit technically changes behavior > and could change behavior of existing user space applications that deal > with this quirky behavior, it's definitely not correct and results in > very unexpected behavior if the user space doesn't look out for it > (meaning only use 0x00-0xFF magnitude, and also know that the magnitude > was interpreted as signed value, see more details in the commit message > there). > > There's currently only one other upstream user of the driver, > qcom/msm8996-xiaomi-gemini where I've added the dts authors to this > patch series (Raffaele & Yassine) and some tests on that device would be > nice since it's operating in LRA mode, mine does in ERM mode. > > Signed-off-by: Luca Weiss <luca@xxxxxxxxx> > --- > Luca Weiss (5): > Input: drv260x - fix typo in register value define > Input: drv260x - sleep between polling GO bit > Input: drv260x - remove unused .reg_defaults > Input: drv260x - fix magnitude handling > ARM: dts: qcom: apq8026-huawei-sturgeon: Add vibrator Applied patches 1-4. Thanks. -- Dmitry
