Re: [PATCH v6 4/5] ARM: dts: imx6sx: Add LDB support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/23/23 13:34, Fabio Estevam wrote:
Hi Marek,

On Mon, May 22, 2023 at 11:57 PM Marek Vasut <marex@xxxxxxx> wrote:

+                             lvds_bridge: bridge@18 {
+                                     compatible = "fsl,imx6sx-ldb";
+                                     reg = <0x18 0x4>;
+                                     clocks = <&clks IMX6SX_CLK_LDB_DI0>;
+                                     clock-names = "ldb";

Since there is only once clock, is this clock-names even needed ?

As of today, clock-names is needed because
drivers/gpu/drm/bridge/fsl-ldb.c retrieves the ldb clock like this:

fsl_ldb->clk = devm_clk_get(dev, "ldb")

If you want, I can change it to fsl_ldb->clk = devm_clk_get(dev, NULL)
and also remove clock-names from
fsl,ldb.yaml and from imx8mp.dtsi.

Or this cleanup can also be a follow-up patch. Just let me know what you prefer.

I think a follow up patch would be perfectly fine , let's not grow the series unnecessarily .



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux