Hi, On Fri, May 19, 2023 at 10:07 PM Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > The ili9882t is a TDDI IC ((Touch with Display Driver)). It requires the > panel reset gpio to be high before i2c commands. Use a longer delay in > post_power_delay_ms to ensure the poweron sequence. > > Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > drivers/hid/i2c-hid/i2c-hid-of-elan.c | 7 +++++++ > 1 file changed, 7 insertions(+) This seems OK to me. The one thing I'd also do is to update the Kconfig description to say that this driver is also used for Ilitek. I think it's fine to keep the symbol name as I2C_HID_OF_ELAN but just change the description. -Doug