Hi, On Fri, May 19, 2023 at 2:02 AM Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > The ili9882t is a TDDI IC ((Touch with Display Driver)). It requires the > panel reset gpio to be high before i2c commands. Use a longer delay in > post_power_delay_ms to ensure the poweron sequence. > > Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 6 ++++++ > 1 file changed, 6 insertions(+) Two comments: 1. You need to submit a bindings patch to document your "ilitek,ili9882t" compatible string. 2. I would tend to add the support to the "i2c-hid-of-elan.c" driver instead of the goodix one. Probably the drivers need to combined again (I'll see if I can post a patch for that before too long), but if I were picking one I'd pick the elan one, I think. -Doug
