On Thu, May 18, 2023 at 12:36:35PM +0100, Biju Das wrote: > As per the HW manual, XTOSCB bit setting is as follows > > If using an external clock signal, set the XTOSCB bit as 1 to > disable the crystal oscillator. > > If using an external crystal, the XTOSCB bit needs to be set at 0 > to enable the crystal oscillator. > > Document clock and clock-names properties. > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> I notice on v3 you appealed to Rob or Krzysztof for approval about this approach. Clearly I not either of them, but it seems reasonable to me. Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks, Conor. > --- > v4: > * New patch > --- > .../devicetree/bindings/rtc/isil,isl1208.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > index 565965147ce6..6c270dd53605 100644 > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > @@ -25,6 +25,19 @@ properties: > reg: > maxItems: 1 > > + clocks: > + maxItems: 1 > + > + clock-names: > + description: | > + Use xin, if connected to an external crystal. > + Use clkin, if connected to an external clock signal. > + oneOf: > + - items: > + - const: xin > + - items: > + - const: clkin > + > interrupts: > minItems: 1 > maxItems: 2 > -- > 2.25.1 >
Attachment:
signature.asc
Description: PGP signature
