在 2023/5/17 17:30, Sudeep Holla 写道:
On Wed, May 17, 2023 at 03:16:12PM +0800, lihuisong (C) wrote:
[...]
No. I want to use this flag to make compability between different platforms.
This driver only use PCC OpRegion to access to the channel if platform
support use PCC OpRegion.
What do you mean by that ? It is not correct. If there is a PCC Opregion,
then you need to make it work with drivers/acpi/acpi_pcc.c
You need to have all the other details in the firmware(ASL). By looking
at the driver, it has no connection to PCC Opregion IMO unless I am missing
something.
Driver just needs to call these APIs, such as acpi_evaluate_integer(),
if want to use PCC OpRegion.
I know that. I have tested PCC OpRegion before.
You've completely misunderstood what I said.😅
I mean that this driver plans to support both PCC and PCC OpRegion.
For example,
Platform A: this driver use PCC (as the current implementation)
Platform B: this driver use PCC OpRegion (Currently, this patch does not
implement it, but it may be available in the future.)
Note:
This driver selects only one of them (PCC and PCC OpRegion) to
communicate with firmware on one platform.
We use one bit in device-flags to know which one this driver will use.
I'm not sure if you can understand what I mean by saing that.
If you're not confused about this now, can you reply to my last email
again?😁
