On 12/05/2023 09:51, Xingyu Wu wrote: > On 2023/5/12 14:50, Krzysztof Kozlowski wrote: >> On Fri, 12 May 2023 10:20:34 +0800, Xingyu Wu wrote: >>> From: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> >>> >>> Add documentation to describe StarFive System Controller Registers. >>> >>> Co-developed-by: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> >>> Signed-off-by: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> >>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >>> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> >>> --- >>> .../soc/starfive/starfive,jh7110-syscon.yaml | 67 +++++++++++++++++++ >>> MAINTAINERS | 7 ++ >>> 2 files changed, 74 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> ./Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/clock/starfive,jh7110-pll.yaml >> >> See https://patchwork.ozlabs.org/patch/1780353 >> >> This check can fail if there are any dependencies. The base for a patch >> series is generally the most recent rc1. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit. > > This patch need patch 1 about pll clock driver binding. > Do I need to merge syscon binding and pll binding together? No, bot has hickups due to failures in Linus' tree, thus false positives are possible. Best regards, Krzysztof