Conor Dooley <conor@xxxxxxxxxx> writes: > [[PGP Signed Part:Undecided]] > On Wed, May 10, 2023 at 04:15:42PM +0100, Aidan MacDonald wrote: >> The AXP192 is another X-Powers PMIC similar to the existing ones. > > In the driver patch the commit message says: > | The AXP192 PMIC is similar to the AXP202/AXP209, but with different > | regulators, additional GPIOs, and a different IRQ register layout. > > That'd be nice to have in the commit message here too, to explain why > you're adding to the enum rather than listing a fallback. > Otherwise, > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Thanks, > Conor. > Will do, I'll send a v2 shortly. Regards, Aidan >> >> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@xxxxxxxxx> >> --- >> Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml >> index f7f0f2c0421a..9ad55746133b 100644 >> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml >> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml >> @@ -90,6 +90,7 @@ properties: >> oneOf: >> - enum: >> - x-powers,axp152 >> + - x-powers,axp192 >> - x-powers,axp202 >> - x-powers,axp209 >> - x-powers,axp221 >> -- >> 2.39.2 >> > > [[End of PGP Signed Part]]
