Re: [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On 10. 5. 2023, at 10:23, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> 
> On 10/05/2023 10:15, Martin Povišer wrote:
>> 
>>> On 10. 5. 2023, at 9:51, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>> 
>>> On 09/05/2023 18:38, Martin Povišer wrote:
>>>> Add a DT schema for the SSM3515 amp by Analog Devices. It's a simple
>>>> mono amplifier with digital input.
>>>> 
>>>> Signed-off-by: Martin Povišer <povik+lin@xxxxxxxxxxx>

>>>> +additionalProperties: true
>>> 
>>> uinevaluatedProperties: false instead, so users can have name-prefix.
>> 
>> I actually tweaked this to have the example passing, which has sound-name-prefix,
> 
> true is not allowed anyway - it makes your schema simply not effective
> almost at all as it allows anything...

That makes sense.

>> which I guess is what you have in mind. Not that I exactly understand what these
>> options do (both additionalProperties and unevaluatedProperties), the schema docs
>> didn’t enlighten me right away when I looked into it.
> 
> The way to go and to start always is to look at example-schema. It tells
> you explicitly to use additionalProperties:false and switch to
> unevaluated "If and only if another schema is referenced".

OK. While I have you on the line, what does unevaluated do? In what sense are props
unevaluated?

> Best regards,
> Krzysztof

Regards,
Martin



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux