Hey Martin, On Tue, May 09, 2023 at 06:38:27PM +0200, Martin Povišer wrote: > Add a DT schema for the SSM3515 amp by Analog Devices. It's a simple > mono amplifier with digital input. > > Signed-off-by: Martin Povišer <povik+lin@xxxxxxxxxxx> > --- > .../bindings/sound/adi,ssm3515.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm3515.yaml > > diff --git a/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml b/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml > new file mode 100644 > index 000000000000..19b7185ae8e2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2019-20 Texas Instruments Incorporated Copyright here looks a little odd, copy & paste from the TI bindings you send patches for earlier, or intended? > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/sound/adi,ssm3515.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" Drop the quotes on these please. > + > +title: Analog Devices SSM3515 Audio Amplifier > + > +maintainers: > + - Martin Povišer <povik+lin@xxxxxxxxxxx> > + > +description: | > + SSM3515 is a mono Class-D audio amplifier with digital input. > + > + https://www.analog.com/media/en/technical-documentation/data-sheets/SSM3515.pdf > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + enum: > + - adi,ssm3515 > + > + reg: > + maxItems: 1 > + > + adi,ana-gain: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3] > + description: | > + The value to be set in the ANA_GAIN register field on the codec. This determines > + the full voltage span of the codec's analog output. > + > + To quote the datasheet on the available options: > + > + 00: 8.4 V Full-Scale Gain Mapping > + 01: 12.6 V Full-Scale Gain Mapping > + 10: 14 V Full-Scale Gain Mapping > + 11: 15 V Full-Scale Gain Mapping Putting register values into the DT does not seem correct, although I know nothing about sound and will have to defer to Krzysztof & Co. on that front. Cheers, Conor. > + > + '#sound-dai-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - adi,ana-gain > + > +additionalProperties: true > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + codec@14 { > + compatible = "adi,ssm3515"; > + reg = <0x14>; > + #sound-dai-cells = <0>; > + adi,ana-gain = <0>; > + sound-name-prefix = "Left Tweeter"; > + }; > + }; > -- > 2.38.3 >
Attachment:
signature.asc
Description: PGP signature