On Tue, 9 May 2023 at 14:56, Varadarajan Narayanan
<quic_varada@xxxxxxxxxxx> wrote:
>
> Add LDO regulator node
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> Changes in v10:
> - Add LDO regulator node
> ---
> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Minor question below:
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> index bdc1434..1f5d14f 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> @@ -60,6 +60,13 @@
> regulator-min-microvolt = <725000>;
> regulator-max-microvolt = <1075000>;
> };
> +
> + mp5496_l2: l2 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + regulator-always-on;
This usually points out that there are other users which are not yet
enabled/properly specified. What users are there for this supply which
demand it to be always on?
> + };
> };
> };
>
> --
> 2.7.4
>
--
With best wishes
Dmitry
