No idea what the second error is about. Documentation/devicetree/bindings/reserved-memory/nvidia,tegra264-bpmp-shmem.yaml does not have a oneOf conditional? Peter. ________________________________________ From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Sent: 08 May 2023 16:33 To: Peter De Schrijver Cc: thierry.reding@xxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; Jonathan Hunter; linux-tegra@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Stefan Kristiansson Subject: Re: [PATCH 4/5] dt-bindings: Add bindings to support DRAM MRQ GSCs On Mon, 08 May 2023 15:20:52 +0300, Peter De Schrijver wrote: > Add bindings for DRAM MRQ GSC support. > > Co-developed-by: Stefan Kristiansson <stefank@xxxxxxxxxx> > Signed-off-by: Stefan Kristiansson <stefank@xxxxxxxxxx> > Signed-off-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx> > --- > .../firmware/nvidia,tegra186-bpmp.yaml | 69 ++++++++++++++++++- > .../nvidia,tegra264-bpmp-shmem.yaml | 40 +++++++++++ > 2 files changed, 106 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/reserved-memory/nvidia,tegra264-bpmp-shmem.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/reserved-memory/nvidia,tegra264-bpmp-shmem.yaml:10:2: [warning] wrong indentation: expected 2 but found 1 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/reserved-memory/nvidia,tegra264-bpmp-shmem.yaml: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property hint: Either unevaluatedProperties or additionalProperties must be present from schema $id: http://devicetree.org/meta-schemas/core.yaml# Documentation/devicetree/bindings/firmware/nvidia,tegra186-bpmp.example.dts:110.31-116.11: ERROR (duplicate_label): /example-1/hsp@3c00000: Duplicate label 'hsp_top0' on /example-1/hsp@3c00000 and /example-0/hsp@3c00000 ERROR: Input tree has errors, aborting (use -f to force output) make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/firmware/nvidia,tegra186-bpmp.example.dtb] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1512: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml See https://patchwork.ozlabs.org/patch/1778345 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. -- nvpublic