On 08/05/2023 00:25, Rob Herring wrote: > > On Sun, 07 May 2023 23:19:20 +0200, Linus Walleij wrote: >> This converts the STMPE MFD device tree bindings to the YAML >> schema. >> >> Reference the existing schema for the ADC, just define the >> other subnode schemas directly in the MFD schema. >> >> Add two examples so we have examples covering both the simple >> GPIO expander and the more complex with ADC and touchscreen. >> >> Some in-tree users do not follow the naming conventions for nodes >> so these DTS files need to be augmented to use proper node names >> like "adc", "pwm", "gpio", "keyboard-controller" etc before the >> bindings take effect on them. >> >> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> --- >> ChangeLog v2->v3: >> - Drop the required pwm properties already required by the >> template pwm schema. >> - Add the number of PWM cells as const. >> ChangeLog v1->v2: >> - Split off the GPIO bindings to their own schema, as the old >> bindings didn't even have any GPIO bindings. Put the GPIO >> schema before this schema so we can use GPIO in the examples. >> - Drop nodename and pattern as STMPE is not a generic name. >> - Add maxItems to the resets. >> - Make wakeup-source just :true, as it is a generic property. >> - Move unevaluatedProperties for subnodes right before properties >> as requested. >> - Name devices "port-expander" in the examples. >> - Use lowercase hex in line init. >> --- >> .../devicetree/bindings/input/stmpe-keypad.txt | 41 --- >> .../bindings/input/touchscreen/stmpe.txt | 108 -------- >> .../devicetree/bindings/mfd/st,stmpe.yaml | 297 +++++++++++++++++++++ >> Documentation/devicetree/bindings/mfd/stmpe.txt | 42 --- >> 4 files changed, 297 insertions(+), 191 deletions(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/mfd/st,stmpe.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/gpio/st,stmpe-gpio.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/st,stmpe.example.dtb: port-expander@43: gpio: False schema does not allow {'compatible': ['st,stmpe-gpio'], 'gpio-controller': True, '#gpio-cells': [[2]], 'interrupt-controller': True, '#interrupt-cells': [[2]], 'st,norequest-mask': [[15790082]]} > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/st,stmpe.yaml > Documentation/devicetree/bindings/mfd/st,stmpe.example.dtb: /example-0/i2c/port-expander@43/gpio: failed to match any schema with compatible: ['st,stmpe-gpio'] > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/st,stmpe.example.dtb: port-expander@41: gpio: False schema does not allow {'compatible': ['st,stmpe-gpio'], 'gpio-controller': True, '#gpio-cells': [[2]], 'interrupt-controller': True, '#interrupt-cells': [[2]]} > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/st,stmpe.yaml > Documentation/devicetree/bindings/mfd/st,stmpe.example.dtb: /example-0/i2c/port-expander@41/gpio: failed to match any schema with compatible: ['st,stmpe-gpio'] > Failures can be ignored, result of previous patch failure. Best regards, Krzysztof
