On 25/04/2023 20:15, Krzysztof Kozlowski wrote:
On 25/04/2023 08:57, Chanh Nguyen wrote:
Add the MAX31790 node as a Fan I2C controller. It controls the
TACH and PWM for Fan Mt.Mitchell system.
Signed-off-by: Chanh Nguyen <chanh@xxxxxxxxxxxxxxxxxxxxxx>
---
arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
index e79f56208b89..6455cf80da0e 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
@@ -477,6 +477,18 @@
line-name = "bmc-ocp0-en-n";
};
};
+
+ max31790@20 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Thank Krzysztof,
I think these node names should be "fan-i2c-0" and "fan-i2c-1". Do you
have any other idea ?
+ compatible = "maxim,max31790";
Unfortunately the compatible is undocumented.
Please run scripts/checkpatch.pl and fix reported warnings.
Best regards,
Krzysztof
Yes Krzysztof,
This compatible has not yes documented.
Should I push a document for max31790 to
./Documentation/devicetree/bindings/ or ask to maintainer (Guenter Roeck
<linux@xxxxxxxxxxxx> or Jean Delvare <jdelvare@xxxxxxxx>) ?
Best regards,
Chanh Ng
