On Tue, 2 May 2023 at 17:27, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > On 1.05.2023 12:58, Bhupesh Sharma wrote: > > Add the default and sleep pinctrl states for SDHC1 & 2 controllers > > on QRB4210 RB2 board. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > index dc80f0bca767..5a5294cc6e45 100644 > > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > @@ -190,6 +190,10 @@ vreg_l24a_2p96: l24 { > > }; > > > > &sdhc_1 { > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&sdc1_state_on>; > > + pinctrl-1 = <&sdc1_state_off>; > property-n > property-names > > Other than that: > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Sure, let me fix this in v3. Thanks, Bhupesh