On 03/05/2023 14:32, Neha Malcom Francis wrote: > Document the binding for TI K3 ESM (Error Signaling Module) block. > > Signed-off-by: Neha Malcom Francis <n-francis@xxxxxx> ??? You were already asked to keep it and it was in v4, so you had to explicitly remove it from your git... It takes me time to figure out what is happening here. But ok, if you do not keep my review, comment follows. ... > + ti,esm-pins: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + integer array of ESM interrupt pins to route to external event pin > + which can be used to reset the SoC. > + minItems: 1 > + maxItems: 255 > + > +additionalProperties: false Put aditionalProperties after required:, just like in example-schema. > + > +required: > + - compatible > + - reg > + - ti,esm-pins Best regards, Krzysztof
