On 01/05/2023 20:51, Artur Weber wrote: > Add bindings for the S6D7AA0 LCD panel controller, including the > S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family > of tablets, and the S6D7AA0-LSL080AL03 and S6D7AA0-LTL101AT01 panels > used in the Samsung Galaxy Tab A 8.0 and 9.7 2015. > > Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx> > --- > Changed in v2: > - Updated commit message > - Applied suggestions from Krzysztof Kozlowski What have changed? > Changed in v3: > - Correctly applied suggestions What have changed? > Changed in v4: > - Added LSL080AL03, LTL101AT01 compatibles > - Added description to reset-gpios > - Added vmipi-supply, renamed enable-supply to power-supply > --- > .../display/panel/samsung,s6d7aa0.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml > new file mode 100644 > index 000000000000..918f62a78ecd > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/samsung,s6d7aa0.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S6D7AA0 MIPI-DSI LCD panel controller > + > +maintainers: > + - Artur Weber <aweber.kernel@xxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + enum: > + # 1280x800 LSL080AL02 panel > + - samsung,s6d7aa0-lsl080al02 lsl080al02 is model number also coming from Samsung? I am afraid this concatenated two compatibles into one... > + # 1024x768 LSL080AL03 panel > + - samsung,s6d7aa0-lsl080al03 > + # 1024x768 LTL101AT01 panel > + - samsung,s6d7aa0-ltl101at01 > + > + reg: true > + > + backlight:> + description: | If there is going to be new version: Do not need '|' unless you need to preserve formatting. > + Backlight to use for the panel. If this property is set on panels > + that have DSI-based backlight control (LSL080AL03 and LTL101AT01), > + it overrides the DSI-based backlight. > + > + reset-gpios: > + description: Reset GPIO pin, usually GPIO_ACTIVE_LOW. > + > + power-supply: > + description: | Do not need '|' unless you need to preserve formatting. > + Main power supply for the panel; the exact voltage differs between > + panels, a Best regards, Krzysztof