Re: [PATCH v6 13/13] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/05/2023 16:34, Jianhua Lu wrote:
  &usb_2 {
@@ -1375,6 +1383,12 @@ pm8150b_role_switch_out: endpoint {
  					remote-endpoint = <&dwc3_role_switch_in>;
  				};
  			};
Should add port@0 for usb_1_hsphy because it is required

Not by the hardware its not. The combophy is exclusively responsible for processing the orientation switch.

The only required port in usb-c-connector is port@0 i.e. you have to have one thing the usb-c-connector can connect to for data-role switching.

Now.. I'd take the input that <&qmpphy_typec_mux_in> is not documented but relies on

commit d56de8c9a17d8f5202d0f37dd06ce186cc512586
Author: Li Jun <jun.li@xxxxxxx>
Date:   Tue Mar 28 16:23:04 2023 +0800

    usb: typec: tcpm: try to get role switch from tcpc fwnode

because that is the case.

I will add something to documentation to capture the case where we use a usb-c-connector to trigger an type-c mux orientation switch.

---
bod



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux