On Tue, 2023-04-25 at 11:28 +0200, Krzysztof Kozlowski wrote: > On 24/04/2023 14:34, Nikita Shubin wrote: > > This adds device tree bindings for the Cirrus Logic EP93xx > > RTC block used in these SoCs. > > Thank you for your patch. There is something to discuss/improve. > > > > > Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> > > --- > > .../bindings/rtc/cirrus,ep93xx-rtc.yaml | 32 > > +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/cirrus,ep93xx- > > rtc.yaml b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx- > > rtc.yaml > > new file mode 100644 > > index 000000000000..d4774e984e7b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/cirrus,ep93xx-rtc.yaml > > @@ -0,0 +1,32 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/cirrus,ep93xx-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Cirrus EP93xx Real Time Clock controller > > + > > +maintainers: > > + - Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> > > + - Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: cirrus,ep9301-rtc > > Why only one compatible? What about ep9307 and ep9312? The same > question > for your previous patch - timer. > > Anyway, if you want to keep it like that, then filename should match > compatible. Or merge it into trivial-rtc like Alexandre suggested. I think i should move it to trivial-rtc - there is no need for a separate file. > > Best regards, > Krzysztof >
