On Thu, Apr 27, 2023 at 11:53 AM Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx> wrote: > On 4/26/2023 10:12 PM, Andy Shevchenko wrote: > > On Wed, Apr 26, 2023 at 6:18 PM Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx> wrote: > >> On 4/26/2023 8:34 PM, andy.shevchenko@xxxxxxxxx wrote: ... > >> Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP"? > > Yes, please. > PINCTRL_PINGROUP cannot be used as it is, since msm_pigroup has multiple > other fields that needs to be set > for each pingroup defined. > Would rename this to SDX75_PINGROUP, as seen on some other platforms. > Would that be ok? For this patch, yes. But can you create a separate followup that replaces three members of struct msm_pingroup by embedding struct pingroup into it? There are examples of such changes in the kernel already. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/drivers/pinctrl?id=39b707fa7aba7cbfd7d53be50b6098e620f7a6d4 -- With Best Regards, Andy Shevchenko
