Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/26/2023 8:34 PM, andy.shevchenko@xxxxxxxxx wrote:
Mon, Apr 24, 2023 at 02:33:50PM +0530, Rohit Agarwal kirjoitti:
Add initial Qualcomm SDX75 pinctrl driver to support pin configuration
with pinctrl framework for SDX75 SoC.
While at it, reordering the SDX65 entry.
...

+#define FUNCTION(fname)							\
+	[msm_mux_##fname] = {						\
+		.name = #fname,						\
+		.groups = fname##_groups,				\
+	.ngroups = ARRAY_SIZE(fname##_groups),				\
+	}
PINCTRL_PINFUNCTION() ?
Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP"?

...

+static const struct of_device_id sdx75_pinctrl_of_match[] = {
+	{.compatible = "qcom,sdx75-tlmm", .data = &sdx75_pinctrl}, {},
One entry per line.
And drop comma in the terminator one.

+};
No MODULE_DEVICE_TABLE()?
Sure Will update both.

Thanks,
Rohit.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux