On 2023/4/21 14:57, Conor Dooley wrote: > On Fri, Apr 21, 2023 at 11:27:52AM +0800, Changhuang Liang wrote: >> On 2023/4/20 1:47, Conor Dooley wrote: >>> On Tue, Apr 18, 2023 at 08:56:44PM -0700, Changhuang Liang wrote: >>>> Move JH7110 private operation into private data of compatible. >>>> Convenient to expand different compatible. >>> >>> I prefer how the code looks in v2, thanks. >>> However, just as in the prior patch, "Convenient to expand different >>> compatible" isn't really a justification - specifically, supporting the >>> power domain controller serving the dphy is your motivation here. The >>> important difference being that it uses a regmap from a syscon and has >>> no interrupts nor the encourage features. >>> >> >> So should I expand the commit message which called "in order to add the >> aon power domain" although the patch is applied behind current patch. > > Only if you have to resend for some other reason. If there is no other > reason to resend then I will do this when I apply the patch. > > Thanks, > Conor. OK, thanks for your support.
