On 2023/4/20 1:47, Conor Dooley wrote: > On Tue, Apr 18, 2023 at 08:56:44PM -0700, Changhuang Liang wrote: >> Move JH7110 private operation into private data of compatible. >> Convenient to expand different compatible. > > I prefer how the code looks in v2, thanks. > However, just as in the prior patch, "Convenient to expand different > compatible" isn't really a justification - specifically, supporting the > power domain controller serving the dphy is your motivation here. The > important difference being that it uses a regmap from a syscon and has > no interrupts nor the encourage features. > So should I expand the commit message which called "in order to add the aon power domain" although the patch is applied behind current patch. > Although, given the only real similarity the code driving each of the > PMUs is the variable names, I guess you could argue that this driver > should be left alone and the "aon dphy" should be a different driver > altogether. > I have tried independent this aon pmu, but it code is very similar to the original pmu, so I think they can put together, reduce linux kernel bloat. > I don't have a strong opinion though & if it's fine with Walker and > noone else objects, it's fine with me...
