Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Thursday, April 20, 2023 4:40 PM
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; linux-
> renesas-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Prabhakar Mahadev
> Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH 3/3] arm64: dts: renesas: rzg2l-smarc: Enable MTU3a
> counter using DT overlay
>
> Hi Biju,
>
> On Mon, Apr 17, 2023 at 11:02 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Enable mtu3 node using dt overlay and disable scif2 node and delete
> > {sd1_mux,sd1_mux_uhs} nodes as the pins are shared with mtu3 external
> > clock input pins and Z phase signal(MTIOC1A).
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-pmod.dtso
> > @@ -0,0 +1,43 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Device Tree Source for the RZ/{G2L,V2L} SMARC EVK PMOD parts
>
> Please add a comment here to document what exactly this provides.
OK will add.
>
> > + *
> > + * Copyright (C) 2023 Renesas Electronics Corp.
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +#include <dt-bindings/pinctrl/rzg2l-pinctrl.h>
> > +
> > +&mtu3 {
> > + pinctrl-0 = <&mtu3_pins>;
> > + pinctrl-names = "default";
> > +
> > + status = "okay";
> > +};
> > +
> > +&pinctrl {
> > + mtu3_pins: mtu3 {
> > + mtu3-zphase-clk {
> > + pinmux = <RZG2L_PORT_PINMUX(19, 0, 3)>; /* MTIOC1A
> */
> > + };
>
> Unless I'm missing something, this signal is not available on the PMOD
> connector?
Yes, it is not available on the PMOD connector. SD card detection signal,
is muxed with MTIOC1A (Z Phase signal). So for counter use case, we use it
as MTIOC1A pins.
>
> > +
> > + mtu3-ext-clk-input-pin {
> > + pinmux = <RZG2L_PORT_PINMUX(48, 0, 4)>, /* MTCLKA
> */
> > + <RZG2L_PORT_PINMUX(48, 1, 4)>; /* MTCLKB
> */
> > + };
>
> So this provides two external clock inputs on the pins on the PMOD connector
> that usually provides a UART?
Yes that is correct. UART signals are muxed with external phase clock inputs.
So for counter use case, using this overlay, we use it is as external phase clock inputs.
>
> > + };
> > +};
> > +
> > +&scif2 {
> > + status = "disabled";
> > +};
> > +
> > +&sdhi1_pins {
> > + /delete-node/ sd1_mux;
> > +};
> > +
> > +&sdhi1_pins_uhs {
> > + /delete-node/ sd1_mux_uhs;
> > +};
>
> As you disable CD functionality, don't you need to add "broken-cd" to the
> sdhi1 node?
OK, will add "broken-cd" to sdhi1 node while using this overlay.
Cheers,
Biju
