On 19/04/2023 12:35, Jayesh Choudhary wrote: >>> + reg-names = "common_m", "common_s0", >>> + "common_s1", "common_s2", >>> + "vidl1", "vidl2","vid1","vid2", >>> + "ovr1", "ovr2", "ovr3", "ovr4", >>> + "vp1", "vp2", "vp3", "vp4", >>> + "wb"; >>> + >>> + clocks = <&k3_clks 218 0>, >> >> Broken indentation. > > Indentation at both places are similar to j721e dss node. > Changes are needed in both? There is no DTS coding style which uses indentation before or after '='. Just because some DTS are written wrong, should not encourage you to do the same... I am commenting only on this patch - it is not correct. What is wrong in other files should be fixed in other places, not relevant to this patch. Best regards, Krzysztof
