On 18/04/2023 23:37, Jakob Hauser wrote: >>> +properties: >>> + compatible: >>> + const: richtek,rt5033-charger >>> + >>> + richtek,pre-microamp: >>> + description: >>> + Current of pre-charge mode. The pre-charge current levels are 350 mA to >>> + 650 mA programmed by I2C per 100 mA. >> >> minimum: >> maximum: >> multipleOf: 100 >> >> Same for other cases. > > The "multipleOf: 100" doesn't seen appropriate to me when the choice is > 350, 450, 550, 650. Those are not multiples of 100. It's more of a step > size. I didn't find a general property for step size. Listing them as > "enum" would be another possibility, I guess, but not an elegant one. > Especially for property "richtek,const-microvolt" there are 30 > possibilities. Ahh, right. You can use enum here and min/max for other cases, where multipleOf cannot be used. >>> + richtek,eoc-microamp: >>> + description: >>> + This property is end of charge current. Its level ranges from 150 mA to >>> + 600 mA. Between 150 mA and 300 mA in 50 mA steps, between 300 mA and 600 mA >>> + in 100 mA steps. >>> + maxItems: 1 > > Here are two different step sizes. The first few are 50 mA steps (150, > 200, 250, 300 mA) and then it changes to 100 mA steps (300, 400, 500, > 600 mA). How to deal with that? Again I guess "enum" would be a > possibility, but again not a nice one. enum Best regards, Krzysztof
