Hi! > The device provides 6 channels which can be individually > turned off and on but groups of two channels share a common brightness > register. > > Limitation: The GPIO to enable the device is not used yet. (I'd expect some explanation how you dealt with the brigthness pairing here. I can figure it out from the fcode, but... I guess you should state it at the begining of driver in a comment at least.). > +++ b/drivers/leds/Kconfig > @@ -551,6 +551,17 @@ config LEDS_REGULATOR > help > This option enables support for regulator driven LEDs. > > +config LEDS_BD2606MVV > + tristate "LED driver for BD2606MVV" > + depends on LEDS_CLASS > + depends on I2C > + select REGMAP_I2C > + help > + This option enables support for BD2606MVV LED driver chips > + accessed via the I2C bus. It supports setting brightness, with > + the limitiation that there are groups of two channels sharing > + a brightness setting, but not the on/off setting. Add the usual note about modules here. Rest looks ok. With that fixed: Acked-by: Pavel Machek <pavel@xxxxxx> BR, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature
