On 2023/4/14 20:37, Rob Herring wrote: > > On Fri, 14 Apr 2023 10:41:55 +0800, Xingyu Wu wrote: >> From: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> >> >> Add documentation to describe StarFive System Controller Registers. >> >> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> >> --- >> .../soc/starfive/starfive,jh7110-syscon.yaml | 58 +++++++++++++++++++ >> MAINTAINERS | 6 ++ >> 2 files changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/clock/starfive,jh7110-pll.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230414024157.53203-6-xingyu.wu@xxxxxxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > I have updated yamllint and dtschema, and tested it and didn't see this error. I asked william and also didn't see this. This error says the file: http://devicetree.org/schemas/clock/starfive,jh7110-pll.yaml was not found. This file is added in patch 1 but patch 1 should be applied after these patchset about JH7110 basic clock drivers. I don't know if that's the reason. Best regards, Xingyu Wu