Re: [PATCH V3 8/9] arm64: dts: Add ipq5018 SoC and rdp432-c2 board support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 4/14/2023 5:01 PM, Konrad Dybcio wrote:


On 14.04.2023 12:29, Sricharan Ramabadhran wrote:
Add initial device tree support for the Qualcomm IPQ5018 SoC and
rdp432-c2 board.

Co-developed-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
Co-developed-by: Gokul Sriram Palanisamy <quic_gokulsri@xxxxxxxxxxx>
Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@xxxxxxxxxxx>
Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
---
  [v3] Fixed all review comments and DTS schema warnings
This is too vague.

  Ha ok, infact below is the list of changes from V2 -> V3


    *) Sorted the nodes based on address.
    *) Removed the pcie fixed clocks.
    *) Changed the board file name.
    *) Added SDHCI nodes/pins.
    *) Fixed the DT schema warnings.
    *) Fixed rest of comments.

[...]

+
+			v2m1: v2m@1000 {
+				compatible = "arm,gic-v2m-frame";
+				reg = <0x00001000 0xffd>;
Doesn't this exceed the ranges=<> of &intc?

  Right, thanks for the catch. Will fix it.

Regards,
 Sricharan



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux