On 16/04/2023 10:46, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@xxxxxxxxxxx> > > The renaming is due to the fact that it is now supporting SoCs other > than Hi3798CV200. Thank you for your patch. There is something to discuss/improve. > - }; > diff --git a/Documentation/devicetree/bindings/mmc/histb-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/histb-dw-mshc.yaml > new file mode 100644 > index 0000000000000..4711ad293b9e8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/histb-dw-mshc.yaml Missing vendor prefix. > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license, unless you copied some part of GPL-2.0 code? > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/histb-dw-mshc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: > + Hisilicon HiSTB SoC specific extensions to the Synopsys Designware Mobile > + Storage Host Controller > + > +maintainers: > + - Yang Xiwen <forbidden405@xxxxxxxxxxx> > + > +description: > + The Synopsys designware mobile storage host controller is used to interface a > + SoC with storage medium such as eMMC or SD/MMC cards. > + > +properties: > + compatible: > + enum: > + - hisilicon,hi3798cv200-dw-mshc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 4 Instead: maxItems: 4 > + > + clock-names: > + items: > + - const: ciu > + - const: biu > + - const: ciu-sample > + - const: ciu-drive > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +allOf: > + - $ref: synopsys-dw-mshc-common.yaml# The order is still different than what you can find in example-schema. required, allOf then unevaluatedProperties.ds, Krzysztof
