On 15/04/2023 19:47, Jonathan McDowell wrote: > This adds a DT node to hook up the internal temperature ADC to the Do not use "This commit/patch", but imperative mood. See: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > iio-hwmon driver. The various voltage + current ADCs are consumed and > exposed by their respective drivers, but this is not and is always > available. Naming chosen to match the axp20x_ prefix the power sensors > use. Weird choice. > > Signed-off-by: Jonathan McDowell <noodles@xxxxxxxx> > --- > arch/arm/boot/dts/axp209.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi > index ca240cd6f6c3..f00b5a7ec106 100644 > --- a/arch/arm/boot/dts/axp209.dtsi > +++ b/arch/arm/boot/dts/axp209.dtsi > @@ -48,6 +48,13 @@ > * http://dl.linux-sunxi.org/AXP/AXP209%20Datasheet%20v1.0_cn.pdf > */ > > +/ { > + axp20x_temp { No underscores in node names. Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "iio-hwmon"; > + io-channels = <&axp_adc 4>; /* Internal temperature */ > + }; > +}; > + > &axp209 { > compatible = "x-powers,axp209"; > interrupt-controller; Best regards, Krzysztof
