On Sat, 15 Apr 2023 18:46:03 +0100 Jonathan McDowell <noodles@xxxxxxxx> wrote: > The C.H.I.P has an rtl8723bs device with the bluetooth interface hooked > up on UART3. Support for this didn't exist in mainline when the DTS was > initially added, but it does now, so enable it. > > Signed-off-by: Jonathan McDowell <noodles@xxxxxxxx> > --- > arch/arm/boot/dts/sun5i-r8-chip.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/sun5i-r8-chip.dts > index fd37bd1f3920..4d72a181d8aa 100644 > --- a/arch/arm/boot/dts/sun5i-r8-chip.dts > +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts > @@ -255,6 +255,10 @@ &uart3 { > pinctrl-0 = <&uart3_pg_pins>, > <&uart3_cts_rts_pg_pins>; > status = "okay"; > + > + bluetooth { > + compatible = "realtek,rtl8723bs-bt"; > + } As the kernel test robot already pointed out, there is a semicolon missing here. Otherwise looks good (dt-validate passes), but don't know if there are any wakeup GPIOs connected (can't seem to find a schematic?). Cheers, Andre > }; > > &usb_otg {