On 2023-04-13 12:34:28, Bryan O'Donoghue wrote:
> Add ports as an optional
"Add the following ports as optional ...:"
>
> port@0 to receive an orientation-switch message from the Type-C port or
> redriver
>
> port@1 to subsequently transmit the orientation-switch on once the PHY has
> finished doing its orientation turn-around.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml
> index d307343388888..9ef69ad12b74a 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc7180-qmp-usb3-dp-phy.yaml
> @@ -65,6 +65,22 @@ properties:
> description: Flag the port as possible handler of orientation switching
> type: boolean
>
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + description: OF graph bindings that model incoming orientation-switch and
> + outgoing orientation-switch messages. An example of an incoming
> + orientation-switch message might come form a Type-C connector or a USB
Nit: form -> from
> + redriver. An example of an output would be a DisplayPort controller.
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Type-C mux orientation-switch input.
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: PHY orientation-siwtch output.
> +
> resets:
> items:
> - description: reset of phy block.
> @@ -279,4 +295,22 @@ examples:
> #clock-cells = <1>;
> #phy-cells = <0>;
> };
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + qmpphy_typec_mux_in: endpoint {
> + remote-endpoint = <&pmic_typec_mux_out>;
> + };
> + };
Nit: space?
- Marijn
> + port@1 {
> + reg = <1>;
> + qmpphy_typec_mux_out: endpoint {
> + remote-endpoint = <&dp_typec_mux_in>;
> + };
> + };
> + };
> };
> --
> 2.39.2
>
