Hi Rob, Hi Krzysztof, On Wed, Apr 12, 2023 at 5:36 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote: > > Add device tree binding for Marvell Armada 38x. > > > > Signed-off-by: Tony Dinh <mibodhi@xxxxxxxxx> > > --- > > > > Changes in v2: > > - Add marvell,38x.yaml. For now, add this binding to the Marvell > > directory to keep it consistent with other Marvell yaml files. > > At a later date and a separate patch, consolidate the Marvell > > yaml files into marvell.yaml. > > > > .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@xxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Thanks for the reviews. After running make dt_binding_check for it seems like hours (on a dual-core 1.8GHz ARM box), I got impatient and used make CHECK_DTBS=y armada-385-thecus-n2350.dtb I'll move this to another faster box and run make dt_binding_check. All the best, Tony
