On 12/04/2023 14:42, Changhuang Liang wrote: > > > On 2023/4/12 19:34, Krzysztof Kozlowski wrote: >> On 12/04/2023 10:45, Changhuang Liang wrote: >>> StarFive SoCs like the jh7110 use a MIPI D-PHY RX controller based on >>> a M31 IP. Add a binding for it. >> >> So this is D-PHY? Or the other patch is D-PHY? The naming is quite >> confusing and your commit msgs are not helping here. >> >> Also the power domain phandle here adds to the confusion. >> > > Yes, this is DPHY, DPHY has rx and tx, and last version we are discussing that > use power domain replace syscon: > https://lore.kernel.org/all/5dc4ddc2-9d15-ebb2-38bc-8a544ca67e0d@xxxxxxxxxxxxxxxx/ The other patch - DPHY PMU - is confusing. Instead of writing short commits, explain more. > >>> >>> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> >>> --- >>> .../bindings/phy/starfive,jh7110-dphy-rx.yaml | 85 +++++++++++++++++++ >>> 1 file changed, 85 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-dphy-rx.yaml >>> > [...] >>> + >>> + power-domains: >>> + maxItems: 1 >>> + >>> + lane_maps: >> >> Why did this appear? Underscores are not allowed. It looks like you >> re-implement some standard property. >> > > Will change to lane-maps. > Yes, according to Vinod advice, lane mapping table use device tree > to parse makes sense. Hm, I have a feeling that I saw such property, so you should dig into existing and in-flight bindings. Best regards, Krzysztof
