On 12/04/2023 04:57, Tony Dinh wrote: > Add device tree binding for Marvell Armada 38x. > > Signed-off-by: Tony Dinh <mibodhi@xxxxxxxxx> Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). This is not DTS. These are bindings. > --- > > Changes in v2: > - Add marvell,38x.yaml. For now, add this binding to the Marvell > directory to keep it consistent with other Marvell yaml files. > At a later date and a separate patch, consolidate the Marvell > yaml files into marvell.yaml. > > .../bindings/arm/marvell/armada-38x.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml marvell,armada-38x.yaml Or just squash it with existing armada bindings... Keeping one binding per one SoC group is a bit a lot. > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > new file mode 100644 > index 000000000000..096bd46d932a > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/marvell/marvell,38x.yaml# Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
