On 2023/4/6 19:54, Conor Dooley wrote: > Gah, I never actually CCed Daire. Apologies for the additional email. > > On Thu, Apr 06, 2023 at 12:47:41PM +0100, Conor Dooley wrote: >> +CC Daire >> >> Hey Minda, >> >> On Thu, Apr 06, 2023 at 07:11:39PM +0800, Minda Chen wrote: >> > This patchset adds PCIe driver for the StarFive JH7110 SoC. >> > The patch has been tested on the VisionFive 2 board. The test >> > devices include M.2 NVMe SSD and Realtek 8169 Ethernet adapter. >> >> I was talking with Daire last week about some changes he's working on >> for the microchip driver, and we seemed to recall an off-list email >> sent to Daire & Bjorn about extracting the common PLDA bits from the >> pcie-microchip-host driver to be used with an (at that point) >> unreleased SoC. Perhaps Bjorn has this in his mailbox somewhere still, >> our corporate mail policy scrubs things from over a year ago & I could >> not find it. >> >> I realised that that may actually have been StarFive, and the driver on >> your GitHub [1] certainly felt very familiar to Daire (he said it was >> very similar to his earlier revisions of his driver). >> >> I've not looked at a diff between this and the version you ship on >> GitHub, but first a quick inspection it mostly just looks like you >> did s/plda/sifive/ on the file. >> >> I'm obviously not a PCI maintainer, but if there are common bits between >> the two drivers, extracting common bits seems like a good idea to me... >Thanks. It is pleasure to using same common codes. Does common bits changes will upstream soon? And I see there are many difference between pcie-microchip-host and our codes. >> https://github.com/starfive-tech/linux/blob/JH7110_VisionFive2_devel/drivers/pci/controller/pcie-plda.c >> > >> > This patchset should be applied after the patchset [1], [2], [3] and[4]: >> > [1] https://patchwork.kernel.org/project/linux-riscv/cover/20230314124404.117592-1-xingyu.wu@xxxxxxxxxxxxxxxx/ >> > [2] https://lore.kernel.org/all/20230315055813.94740-1-william.qiu@xxxxxxxxxxxxxxxx/ >> > [3] https://patchwork.kernel.org/project/linux-phy/cover/20230315100421.133428-1-changhuang.liang@xxxxxxxxxxxxxxxx/ >> > [4] https://patchwork.kernel.org/project/linux-usb/cover/20230406015216.27034-1-minda.chen@xxxxxxxxxxxxxxxx/ >> >> How many of the dependencies here are compiletime for the driver & how >> many of them are just for the dts patch? >> PCIe rely on stg clock in [1], rely on stg syscon in [2]. Patch [2] is accepted now. Maybe I will delete this. both [3] and [4] is PHY dependency. >> Cheers, >> Conor. > >
