Re: [net-next v9 4/6] dt-bindings: net: Add support StarFive dwmac From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> to: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx data: 2023/4/5 > On 28/03/2023 08:20, Samin Guo wrote: >> From: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> >> >> Add documentation to describe StarFive dwmac driver(GMAC). >> >> Signed-off-by: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> >> Signed-off-by: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >> .../bindings/net/starfive,jh7110-dwmac.yaml | 144 ++++++++++++++++++ >> MAINTAINERS | 6 + >> 3 files changed, 151 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index e4519cf722ab..245f7d713261 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -91,6 +91,7 @@ properties: >> - snps,dwmac-5.20 >> - snps,dwxgmac >> - snps,dwxgmac-2.10 >> + - starfive,jh7110-dwmac >> >> reg: >> minItems: 1 >> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> new file mode 100644 >> index 000000000000..5861426032bd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> @@ -0,0 +1,144 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 DWMAC glue layer >> + >> +maintainers: >> + - Emil Renner Berthing <kernel@xxxxxxxx> >> + - Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> >> + >> +select: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - starfive,jh7110-dwmac >> + required: >> + - compatible >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - starfive,jh7110-dwmac >> + - const: snps,dwmac-5.20 >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: GMAC main clock >> + - description: GMAC AHB clock >> + - description: PTP clock >> + - description: TX clock >> + - description: GTX clock >> + >> + clock-names: >> + items: >> + - const: stmmaceth >> + - const: pclk >> + - const: ptp_ref >> + - const: tx >> + - const: gtx >> + >> + interrupts: >> + minItems: 3 >> + maxItems: 3 >> + >> + interrupt-names: >> + minItems: 3 >> + maxItems: 3 >> + >> + resets: >> + items: >> + - description: MAC Reset signal. >> + - description: AHB Reset signal. >> + >> + reset-names: >> + items: >> + - const: stmmaceth >> + - const: ahb >> + >> + starfive,tx-use-rgmii-clk: >> + description: >> + Tx clock is provided by external rgmii clock. >> + type: boolean >> + >> + starfive,syscon: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + items: >> + - items: >> + - description: phandle to syscon that configures phy mode >> + - description: Offset of phy mode selection >> + - description: Shift of phy mode selection >> + description: >> + A phandle to syscon with two arguments that configure phy mode. >> + The argument one is the offset of phy mode selection, the >> + argument two is the shift of phy mode selection. >> + >> +allOf: >> + - $ref: snps,dwmac.yaml# >> + >> +unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - interrupts >> + - interrupt-names >> + - resets >> + - reset-names > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. > > > Best regards, > Krzysztof > Hi Krzysztof, Sorry about that I missed this: required: goes after properties I'll fix it :) Best regards, Samin
