From: Krzysztof Kozlowski [mailto:krzk@xxxxxxxxxx] Sent: Thursday, April 6, 2023 10:38 PM > On 06/04/2023 21:57, Christoph Niedermaier wrote: >>>>>> + aliases { >>>>>> + /delete-property/ mmc0; /* Avoid double definitions */ >>>>> >>>>> I don't understand it. What is "double definition" of aliases? >>>> >>>> Otherwise I end up like this: >>>> mmc0 = &usdhc1; >>>> mmc1 = &usdhc2; >>>> mmc2 = &usdhc2; >>>> >>>> Is "Ensure unique allocation" a better comment here? >>>> >>>>> >>>>>> + /delete-property/ mmc1; >>>>>> + mmc2 = &usdhc2; /* eMMC should be mmc2 */ >>>>> >>>>> Why? How is this labeled on the board (physically or on schematics)? If >>>>> you answer here "for booting", then the answer is NAK. Don't add >>>>> software policies to Devicetree. >>>> >>>> The name in the schematics is "SD2". >>> >>> Answering also to above - then likely the aliases should be dropped from >>> SoM. I doubt that Som calls it SD1 and your board SD2... >> >> Maybe I don't quite get it, but the hardware starts counting at 1. The first >> interface is SD1 and it is used as WiFi. The second one is SD2 which is the >> eMMC. So with this aliases it should match SD2 to mmc2. >> Do you want me to delete the aliases in the include file "imx6ull-dhcor-som.dtsi" > > Yes, because it incorrectly calls eMMC as mmc1. You said it is SD2, right? Yes. I will do this in version 3. Thanks and best regards Christoph
