From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] Sent: Thursday, April 6, 2023 6:40 PM > On 06/04/2023 17:49, Christoph Niedermaier wrote: >> Add support for Marantec maveo box. The system is used to get a >> smart conntection to a door drive. It has USB, WiFi, Bluetooth, >> Zigbee and NFC interfaces. The core of this system is a soldered >> i.MX6ULL DHCOR SoM from DH electronics. >> >> Signed-off-by: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx> >> --- >> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> >> Cc: Shawn Guo <shawnguo@xxxxxxxxxx> >> Cc: Li Yang <leoyang.li@xxxxxxx> >> Cc: Marek Vasut <marex@xxxxxxx> >> Cc: Fabio Estevam <festevam@xxxxxxx> >> Cc: NXP Linux Team <linux-imx@xxxxxxx> >> Cc: kernel@xxxxxxxxxxxxxxxxxx >> Cc: devicetree@xxxxxxxxxxxxxxx >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >> --- >> V2: - Correct the vendor prefix >> - Change pinconfig of User and Reset button >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts | 361 ++++++++++++++++++++++++++ >> 2 files changed, 362 insertions(+) >> create mode 100644 arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index aa8fb4b7cdcc..58d3334164e2 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -751,6 +751,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \ >> imx6ull-dhcom-drc02.dtb \ >> imx6ull-dhcom-pdk2.dtb \ >> imx6ull-dhcom-picoitx.dtb \ >> + imx6ull-dhcor-maveo-box.dtb \ >> imx6ull-jozacp.dtb \ >> imx6ull-kontron-bl.dtb \ >> imx6ull-myir-mys-6ulx-eval.dtb \ >> diff --git a/arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts >> new file mode 100644 >> index 000000000000..83bacac19933 >> --- /dev/null >> +++ b/arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts >> @@ -0,0 +1,361 @@ >> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT >> +/* >> + * Copyright (C) 2023 DH electronics GmbH >> + * Copyright (C) 2023 Marantec electronics GmbH >> + * >> + * DHCOM iMX6ULL variant: >> + * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG >> + * DHCOR PCB number: 578-200 or newer >> + * maveo box PCB number: 525-200 or newer >> + */ >> + >> +/dts-v1/; >> + >> +#include "imx6ull-dhcor-som.dtsi" >> + >> +/ { >> + model = "DH electronics i.MX6ULL DHCOR on maveo box"; >> + compatible = "marantec,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som", >> + "fsl,imx6ull"; >> + >> + aliases { >> + /delete-property/ mmc0; /* Avoid double definitions */ > > I don't understand it. What is "double definition" of aliases? Otherwise I end up like this: mmc0 = &usdhc1; mmc1 = &usdhc2; mmc2 = &usdhc2; Is "Ensure unique allocation" a better comment here? > >> + /delete-property/ mmc1; >> + mmc2 = &usdhc2; /* eMMC should be mmc2 */ > > Why? How is this labeled on the board (physically or on schematics)? If > you answer here "for booting", then the answer is NAK. Don't add > software policies to Devicetree. The name in the schematics is "SD2". Regards Christoph
