On 04/04/23 14:42, Bhavya Kapoor wrote:
> Remove sdhci-caps-mask to enable support for SDR104 speed mode for
> SD card in J721S2 SoC.
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@xxxxxx>
> ---
Your commit message doesn't explain why?
Why was this disabled initalially and why is it okay to enable this now?
If disabling SDR104 was a bug, please add Fixes:
> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 8915132efcc1..95c6151ed10c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -400,8 +400,6 @@ main_sdhci1: mmc@4fb0000 {
> ti,clkbuf-sel = <0x7>;
> ti,trm-icp = <0x8>;
> dma-coherent;
> - /* Masking support for SDR104 capability */
> - sdhci-caps-mask = <0x00000003 0x00000000>;
> };
>
> main_navss: bus@30000000 {
--
Regards
Vignesh
