On 05/04/2023 21:47, Cristian Ciocaltea wrote: > Extend the existing fan53555 driver to support the Rockchip RK860X > regulators. > > RK8600/RK8601 are fully compatible with FAN53555 regulators. > > @@ -531,6 +634,18 @@ static const struct of_device_id __maybe_unused fan53555_dt_ids[] = { > }, { > .compatible = "fcs,fan53555", > .data = (void *)FAN53555_VENDOR_FAIRCHILD > + }, { > + .compatible = "rockchip,rk8600", > + .data = (void *)FAN53555_VENDOR_ROCKCHIP > + }, { > + .compatible = "rockchip,rk8601", > + .data = (void *)FAN53555_VENDOR_ROCKCHIP > + }, { > + .compatible = "rockchip,rk8602", > + .data = (void *)RK8602_VENDOR_ROCKCHIP > + }, { > + .compatible = "rockchip,rk8603", > + .data = (void *)RK8602_VENDOR_ROCKCHIP > }, { > .compatible = "silergy,syr827", > .data = (void *)FAN53555_VENDOR_SILERGY, > @@ -637,6 +752,18 @@ static const struct i2c_device_id fan53555_id[] = { > }, { > .name = "fan53555", > .driver_data = FAN53555_VENDOR_FAIRCHILD > + }, { > + .name = "rk8600", > + .driver_data = FAN53555_VENDOR_ROCKCHIP > + }, { > + .name = "rk8601", > + .driver_data = FAN53555_VENDOR_ROCKCHIP Why do you need this entry match data if it is the same as rk8600? > + }, { > + .name = "rk8602", > + .driver_data = RK8602_VENDOR_ROCKCHIP > + }, { > + .name = "rk8603", > + .driver_data = RK8602_VENDOR_ROCKCHIP Why do you need this entry match data if it is the same as rk8602? Best regards, Krzysztof